[jdk17] Integrated: 8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation

Stefan Johansson sjohanss at openjdk.java.net
Wed Jun 16 09:02:39 UTC 2021


On Fri, 11 Jun 2021 13:47:49 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> Please review this test-fix to avoid failures on certain platforms.
> 
> **Summary**
> Fixes an incorrect calculation in the test when trying to predict the new size given the `NewRatio`. The fix is not strictly bound to different platforms but to the resulting heap-size the test is run with. Both with Serial and Parallel the test fails if run on a platform using a heap alignment that forces the heap to be 104 MB instead of the specified 100 MB. It is a bit unclear why the test even passes with 100MB, since the calculation done in the test doesn't match the calculation done in the JVM. 
> 
> **Testing**
> Manual testing to verify the fix actually fixes the issue and works with multiple page sizes. Mach5 testing on affected platforms to verify the fix is good there as well.

This pull request has now been integrated.

Changeset: 59de99d1
Author:    Stefan Johansson <sjohanss at openjdk.org>
URL:       https://git.openjdk.java.net/jdk17/commit/59de99d11988b7f1ab20e323f3dc4d0d49e3b7a3
Stats:     6 lines in 1 file changed: 2 ins; 0 del; 4 mod

8267271: Fix gc/arguments/TestNewRatioFlag.java expectedNewSize calculation

Reviewed-by: tschatzl, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk17/pull/28


More information about the hotspot-gc-dev mailing list