RFR: 8266746: C1: Replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block [v4]

Yi Yang yyang at openjdk.java.net
Tue Jun 29 06:21:33 UTC 2021


> After JDK-8150921, most Unsafe{Get,Put}Raw intrinsic methods can be replaced by Unsafe{Get,Put}Object.
> 
> There is the only one occurrence where c1 refers UnsafeGetRaw among GraphBuilder::setup_osr_entry_block()
> 
> https://github.com/openjdk/jdk/blob/74fecc070a6462e6a2d061525b53a63de15339f9/src/hotspot/share/c1/c1_GraphBuilder.cpp#L3143-L3157
> 
> We can replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block. After that, Unsafe{Get,Put}Raw can be completely removed  because no one refers to them.
> 
> (This patch actually does two things:
> 1. `Replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block` This is the only occurrence where c1 refers UnsafeGetRaw
> 2. `Cleanup unused Unsafe{Get,Put}Raw code`
> They are related so I put it together, but I still want to hear your suggestions, I will separate them into two patches if you think it is more reasonable)
> 
> Thanks!
> Yang

Yi Yang has updated the pull request incrementally with one additional commit since the last revision:

  remove unaligned assert

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3917/files
  - new: https://git.openjdk.java.net/jdk/pull/3917/files/be6b9891..3e5b83da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3917&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3917&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3917.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3917/head:pull/3917

PR: https://git.openjdk.java.net/jdk/pull/3917


More information about the hotspot-gc-dev mailing list