RFR: 8266746: C1: Replace UnsafeGetRaw with UnsafeGetObject when setting up OSR entry block [v3]

Yi Yang yyang at openjdk.java.net
Tue Jun 29 06:21:37 UTC 2021


On Mon, 28 Jun 2021 16:13:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   many nit
>
> src/hotspot/share/c1/c1_LIRGenerator.cpp line 2114:
> 
>> 2112:     LIR_Address* addr = new LIR_Address(src.result(), offset, type);
>> 2113:     if (type == T_LONG || type == T_DOUBLE) {
>> 2114:       __ unaligned_move(addr, result);
> 
> You're always using unaligned_move. Old code checks x->may_be_unaligned(). May be ok, though.

Thank you Martin for running these tests!

In this case, may_be_unaligned is must-be-unaligned since setup_osr_entry_block always creates unaligned UnsafeGetRaw before.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3917


More information about the hotspot-gc-dev mailing list