RFR: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
lkorinth at openjdk.java.net
Wed Jun 30 09:04:05 UTC 2021
On Fri, 18 Jun 2021 17:43:05 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> can I have reviews for this change to a test that incorrectly assumed that GCs take 1ms minimum?
> At the end of the test, MXBeans' `getCollectionTime()` is compared against one taken two gcs earlier. If these two gcs are very short, `getCollectionTime()` returns the same value as before because its resolution is 1ms.
> The `getCollectionTime()` documentation states:
>> Returns the approximate accumulated collection elapsed time in milliseconds. This method returns -1 if the collection elapsed time is undefined for this collector.
>> The Java virtual machine implementation may use a high resolution timer to measure the elapsed time. **This method may return the same value even if the collection count has been incremented if the collection elapsed time is very short.**
> Which is what the test tested
> Testing: test does not fail any more after some VM hack so that `getCollectionTime()` returns very low values.
Looks good to me.
Marked as reviewed by lkorinth (Committer).
More information about the hotspot-gc-dev