RFR: 8269032: Stringdedup tests are failing if the ergonomically select GC does not support it

Leo Korinth lkorinth at openjdk.java.net
Wed Jun 30 09:41:01 UTC 2021


On Wed, 30 Jun 2021 06:28:08 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> I think we should just blindly pass this option (or options) to the spawned JVMs, without looking at them.
>
> I don't think there's any point to doing any parsing here, and good reason not to.  If the value isn't sensible as a GC name the test will very likely fail because of an invalid CLA to the subprocess.  And validating that it's a valid GC name involves using vm.gc.GC, which brings in WhiteBox and all its attendant cruft.

Okay, but is it not better then to skip the string concatenation part and give the complete flag directly as an argument to the driver directive?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4603


More information about the hotspot-gc-dev mailing list