RFR: 8276129: PretouchTask should page-align the chunk size

Thomas Schatzl tschatzl at openjdk.java.net
Wed Nov 3 12:15:19 UTC 2021


On Tue, 2 Nov 2021 01:28:38 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to PretouchTask to page-align the chunk size.
> Aligning down is used because it's easy; aligning up would require dealing
> with possible overflow or verifying that overflow isn't possible.
> 
> Testing:
> mach5 tier1
> 
> Locally (linux-x64) java -version with pretouch task logging and various
> chunk sizes, manually verifying the number of workers was as expected.

Lgtm independent of whether you want to incorporate @stefank 's suggestion.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6204


More information about the hotspot-gc-dev mailing list