RFR: 8276098: Do precise BOT updates in G1 evacuation phase [v3]

Stefan Johansson sjohanss at openjdk.java.net
Tue Nov 9 08:57:16 UTC 2021


On Mon, 8 Nov 2021 15:30:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Thomas review
>
> src/hotspot/share/gc/shared/plab.hpp line 122:
> 
>> 120: 
>> 121:   // Sets the space of the buffer to be [buf, space+word_sz()).
>> 122:   virtual void set_buf(HeapWord* buf, size_t new_word_sz) {
> 
> I wonder if `override` is better.

This is the base class so this is not an `override` but declaring the function as `virtual`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6166


More information about the hotspot-gc-dev mailing list