RFR: 8276098: Do precise BOT updates in G1 evacuation phase [v3]

Albert Mingkun Yang ayang at openjdk.java.net
Tue Nov 9 09:21:43 UTC 2021


On Tue, 9 Nov 2021 09:00:21 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1Allocator.hpp line 159:
>> 
>>> 157:   G1BotUpdatingPLAB(size_t word_sz) : PLAB(word_sz) { }
>>> 158:   // Sets the new PLAB buffer as well as updates the threshold and region.
>>> 159:   virtual void set_buf(HeapWord* buf, size_t word_sz);
>> 
>> Is `override` better here?
>
> I can change this to `override` if you prefer. I see that we have some uses of it in G1 already.

Yes please, since it makes the intention explicit and enforces it in compile-time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6166


More information about the hotspot-gc-dev mailing list