RFR: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate [v4]

Hamlin Li mli at openjdk.java.net
Wed Nov 10 01:30:07 UTC 2021


> Currently, G1EvacFailureObjectsSet::iterate(ObjectClosure* closure) is not a const method, but it looks like a const method. It will be a surprise for reader, i.e. you would not expect that an iteration method is destructive, clearing out the set it just iterated over.
> We should refine it in some way.

Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:

  Refine comments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6303/files
  - new: https://git.openjdk.java.net/jdk/pull/6303/files/21188299..4d876798

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6303&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6303&range=02-03

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6303.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6303/head:pull/6303

PR: https://git.openjdk.java.net/jdk/pull/6303


More information about the hotspot-gc-dev mailing list