RFR: 8272773: Configurable card table card size [v8]

Vishal Chand duke at openjdk.java.net
Fri Nov 19 05:10:44 UTC 2021


On Thu, 18 Nov 2021 21:49:14 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Vishal Chand has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change to avoid compilation issue in hs builds
>
> src/hotspot/share/gc/g1/heapRegion.cpp line 94:
> 
>> 92: 
>> 93:   // Initialize card size
>> 94:   CardTable::initialize_card_size();
> 
> I see that `CardTable::initialize_card_size()` is called at the beginning of `GCArguments::initialize_alignments()` for Serial and Parallel. I wonder if it makes sense to do the same for G1.

The reason for having `CardTable::initialize_card_size()` here in the initial patch was the dependency between card size and G1 heap region size. Since the dependency is no longer there, we can safely move this initialization to `G1Arguments::initialize_alignments`

-------------

PR: https://git.openjdk.java.net/jdk/pull/5838


More information about the hotspot-gc-dev mailing list