RFR: 8276670: G1: Move and rename G1CardSetFreePool and related classes [v6]
Albert Mingkun Yang
ayang at openjdk.java.net
Mon Nov 22 09:44:12 UTC 2021
On Fri, 19 Nov 2021 04:49:59 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Currently, only the card sets (remembered sets) use G1CardSetFreePool to give back memory to OS.
>> After JDK-8254739, this memory reclaiming mechanism could be reused by evacuation failure too. This is a preparation change to allow reuse of this code.
>> I plan to do this in about 3 steps to smooth the review process:
>> 1. move G1CardSetFreePool and related classes to new file, rename these classes
>> 2. refactor these classes to support freeing other freelist
>> 3. some necessary cleanup
>> This is to simply move and rename G1CardSetFreePool and related classes, as G1CardSetFreePool and related classes are going to be reused outside of the remembered set, they should be factored out and renamed.
>> Rename from G1CardSetXxx -> G1BufferListXxx.
> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> - Merge with master
> - Rename card set to segmented array
> - Rename from G1BufferListXxx to G1SegmentedArrayXxx
> - Fix typo
> - Merge branch 'master' into rename-move-G1CardSetFreePool-out
> - Fix typos
> - Fix gtest tests
> - Fix missing in test
> - Fix missing files
> - move g1CardSetFreeMemoryTask.*
> - ... and 1 more: https://git.openjdk.java.net/jdk/compare/2f0bde1a...7cfe01fb
I think splitting "move" and "rename" into two PRs (the current commits history is a bit hard to follow) will make the review process much easier and the included meaningful changes more discernible.
More information about the hotspot-gc-dev