RFR: 8277560: Remove WorkerDataArray::_is_serial [v2]

Stefan Johansson sjohanss at openjdk.java.net
Mon Nov 22 15:07:21 UTC 2021


On Mon, 22 Nov 2021 15:03:28 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple change of removing effectively dead code.
>> 
>> Test: build
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

Looks good, but please do the additional removal mentioned below.

src/hotspot/share/gc/shared/workerDataArray.inline.hpp line 173:

> 171:   if (start < _length) {
> 172:     if (_is_serial) {
> 173:       WDAPrinter::summary(out, get(0));

>From what I can tell these two function will no longer be used after your change:

WDAPrinter::summary(outputStream* out, double time);
WDAPrinter::summary(outputStream* out, size_t value);

Please remove them.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6502


More information about the hotspot-gc-dev mailing list