RFR: 8277807: Increase default initial concurrent refinement threshold [v2]
tschatzl at openjdk.java.net
Tue Nov 30 08:36:05 UTC 2021
On Thu, 25 Nov 2021 04:32:32 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change to the default initial concurrent refinement
>> threshold. The new value takes into account options that should provide a
>> starting point that is closer to the long-term range.
>> mach5 tier1
>> manually verified logged initial value matched expectations.
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> update copyright
src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 258:
> 256: // rate_1 is a relatively conservative guess at the rate for pause-time
> 257: // card refinement by one thread.
> 258: const double rate_1 = 200.0; // cards/ms/thread
I would prefer if this magic number were placed somewhere more standing out than in some static method in a cpp file. I thought at least put it into the .hpp file as part of the `G1ConcurrentRefine" class. However there are no guidelines for that for g1 code where or how to collect these magic constants I'm kind of good with that too.
Marked as reviewed by tschatzl (Reviewer).
More information about the hotspot-gc-dev