Review Request: 6896043: Zero fixes
gbenson at redhat.com
Mon Nov 23 02:18:23 PST 2009
Vladimir Kozlov wrote:
> > hotspot/src/cpu/zero/vm/entry_zero.hpp:
> To be clear. You did it to inline methods in debug VM version,
> right? They will be optimized for optimized builds anyway.
No, I did it to inline them for the optimized build. I'd assumed
that methods defined in header files like that would be inlined,
but they don't seem to be. Maybe this is a peculiarity of the
IcedTea build, which is where I noticed the problem. If it is,
I can remove it from this webrev.
> > hotspot/src/cpu/zero/vm/frame_zero.hpp,
> > hotspot/src/cpu/zero/vm/frame_zero.cpp:
> Can you add at least an assert into sender_for_nonentry_frame() to
> verify expected frame types?
> > hotspot/src/share/vm/runtime/os.hpp:
> Can you explain why your changes is not the same as the comment
> says?: ((_mem_serialize_page ^ addr) & -pagesize) == 0
Basically because I didn't know if I'd need to make changes anywhere
else, and I didn't want to break the other platforms. Should I change
it to what the comment says?
More information about the hotspot-runtime-dev