Review Request: 6896043: Zero fixes

Andrew Haley aph at
Tue Nov 24 02:38:57 PST 2009

Gary Benson wrote:
> Andrew Haley wrote:
>> If you really want these functions to be inline, you have to specify
>> it.  Having said that, if you define a member function within a class
>> definition, then it is inline.
> I never thought to check that the inline statement was actually doing
> anything, but apparently it isn't:

It won't: functions defined within a class definition are inline anyway.

> First things first: I'll remove the addition of the inline statements
> from the webrev.  Secondly, Andrew, do you have any idea why these
> functions aren't being inlined? 

Are you sure they aren't being inlined?  I'd have to look at the code to
be sure.  This stack trace doesn't prove it.

Not immediately.  I'd experiment with __attribute__((always_inline)) and
see what happens.  If gcc actually can't inline for some reason, it'll
produce a diagnostic.


More information about the hotspot-runtime-dev mailing list