need a code review for a quick test fix (6971847)
Alan.Bateman at oracle.com
Sun Jul 25 03:48:24 PDT 2010
Daniel D. Daugherty wrote:
> Yes, I would prefer that the test code be the same across
> releases. Thanks for approval for OpenJDK6.
It makes sense to use the same test for jdk6 and jdk7 but it's not clear
to me that these tests are useful for the older proprietary releases.
For starters, we didn't have -histo:live so the test will fail. Also, I
think Windows will bite you again because we didn't include jmap on
Windows until jdk6. My guess is you'll need a completely different test.
Anyway, as I said, I don't have any objection to the proposed test
changes and I'm just pointing you that we shouldn't need any of this
detection code in the tests checked into the jdk6 and jdk7 repos.
More information about the hotspot-runtime-dev