Second Code Review for WeakReference leak in the Logging API (6942989)

Alan Bateman Alan.Bateman at
Tue Jun 22 13:34:25 PDT 2010

Daniel D. Daugherty wrote:
> :
> Here is the URL for the webrev:
> Thanks, in advance, for any reviews.
Sorry for the late reply. Using the reference queue is much better. I've 
looked through the new webrev and the approach seems reasonable. 

One nit is that the style is perhaps a bit different to the existing 
code. For example, the alignment of the declarations in LoggerWeakRef is 
different to the enclosing class and the other classes in this package, 
the new package-private methods are final whereas the existing 
package-private methods aren't. Nothing wrong, just looks a bit different.

One question, in drainLoggerRefQueueBounded I'm curious about the check 
for loggerRefQueue being null. Is that needed?


More information about the hotspot-runtime-dev mailing list