Review Request: Zero JNI handles fix

Keith McGuigan keith.mcguigan at
Tue Mar 30 06:55:22 PDT 2010

On 03/30/10 05:52, Christian Thalinger wrote:
> On Mon, 2010-03-29 at 16:24 +0100, Gary Benson wrote:
>> Hi all,
>> Zero will exit with an error when invoked with -Xcheck:jni.
>> This webrev fixes:
>> Note that this is actually a pretty old issue, but the fix
>> for it got lost from the IcedTea repositories.  There's more
>> information here:
>> I don't have a bug id for this.
> 6939182: Zero JNI handles fix
> I guess the changes are good since it uses an #ifdef.  Maybe one of the
> runtime guys could also comment on this one.

It would be better to put this in zero-specific code somewhere instead 
of polluting common code with #ifdef, but if that's not possible...

Also, instead of this point-fix in jniHandles, why not fix 
last_Java_sp() to return zero_stack()->sp() in the zero case?  This is 
not the only place last_Java_sp() is called.  Might want to fix it for 
last_Java_pc() (and related) too.

- Keith

More information about the hotspot-runtime-dev mailing list