Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
David.Holmes at oracle.com
Wed Jan 5 15:15:49 PST 2011
Coleen Phillimore said the following on 01/06/11 06:14:
> Summary: Call get_thread_slow() in vm_perform_shutdown actions and add
> null check.
Looks fine. A minor nit - you'd preserve the abstraction boundary more
if you checked is_initialized() rather than explicitly comparing the
index against -1
> Tested by forcing vm_exit_out_of_memory in current_stack_region (if
> is_init_completed) to reproduce the bug.
> open webrev at http://cr.openjdk.java.net/~coleenp/6583275/
> bug link at http://bugs.sun.com/view_bug.do?bug_id=6583275
More information about the hotspot-runtime-dev