Request for review 6583275: Hotspot crash in vm_perform_shutdown_actions due to uninitialized TLS duri,ng out of memory handling
John.Coomes at oracle.com
Wed Jan 5 18:38:45 PST 2011
Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
> Thanks, John and David for the same comment. I found the thread_index()
> != 1 check in code above so changed them both to is_initialized() and
> reversed the ?: see:
Looks good to me.
> On 1/5/2011 6:26 PM, John Coomes wrote:
> > Coleen Phillimore (coleen.phillimore at oracle.com) wrote:
> >> Summary: Call get_thread_slow() in vm_perform_shutdown actions and add
> >> null check.
> >> Tested by forcing vm_exit_out_of_memory in current_stack_region (if
> >> is_init_completed) to reproduce the bug.
> >> open webrev at http://cr.openjdk.java.net/~coleenp/6583275/
> >> bug link at http://bugs.sun.com/view_bug.do?bug_id=6583275
> > You should use ThreadLocalStorage::is_initialized() instead of
> > checking for -1. Other than that, looks good.
> > -John
More information about the hotspot-runtime-dev