Pls review 7011463 (S)

Christian Thalinger christian.thalinger at
Tue Jan 11 03:37:43 PST 2011

On Jan 11, 2011, at 12:25 PM, Paul Hohensee wrote:
> Sparc MacroAssembler::incr_allocated_bytes() needs a RegisterOrConstant argument.
> Webrev here
> Christian, I should have implemented your suggestion. :(
> Turns out that some constant object sizes are larger than 4kb (what fits in a simm13),
> which will cause assertions once in awhile when an attempt is made to generate
> an add-immediate instruction.

Looks good.  Other uses of RegisterOrConstant don't call the constructor explicitly when passing in as argument, but that's just a nit.

-- Christian

More information about the hotspot-runtime-dev mailing list