Pls review 7011463 (S)

Paul Hohensee paul.hohensee at
Tue Jan 11 14:16:42 PST 2011


On 1/11/11 12:50 PM, John Coomes wrote:
> Christian Thalinger (christian.thalinger at wrote:
>> On Jan 11, 2011, at 12:25 PM, Paul Hohensee wrote:
>>> Sparc MacroAssembler::incr_allocated_bytes() needs a RegisterOrConstant argument.
>>> Webrev here
>>> Christian, I should have implemented your suggestion. :(
>>> Turns out that some constant object sizes are larger than 4kb (what fits in a simm13),
>>> which will cause assertions once in awhile when an attempt is made to generate
>>> an add-immediate instruction.
>> Looks good.  Other uses of RegisterOrConstant don't call the constructor explicitly when passing in as argument, but that's just a nit.
> Looks good to me also.  In case you're taking a poll, I'd vote to
> remove the explicit calls to the ctor to reduce clutter.
> -John

More information about the hotspot-runtime-dev mailing list