review request (S): 6962930 make the string table size configurable

John Coomes John.Coomes at
Sat Mar 19 21:51:21 PDT 2011

John Coomes (John.Coomes at wrote:
> David Holmes (David.Holmes at wrote:
> > Can clarify in globals.hpp whether the size is in bytes, KB, MB.
> Thanks for taking a look.
> It's the number of buckets; I included that info in the doc string and
> updated the webrev (same location).

I've updated the webrev again based on feedback from Coleen.  I
changed arguments.cpp so that if a non-default StringTableSize is
used, it ensures that class data sharing is disabled.  See the same

I plan to push this tomorrow; a review of this latest snippet isn't
critical (Coleen suggested the idea, and it's simply setting flag


> > John Coomes said the following on 02/17/11 04:06:
> > > I'd appreciate reviews of a small change to allow the string table
> > > size to be set on the command line:
> > > 
> > >
> > > 
> > > -John
> > > 

More information about the hotspot-runtime-dev mailing list