Request for review (S): 7099454 /bin/sh does not support syntax used in the src/os/posix/launcher/launcher.script shell script

Bengt Rutisson bengt.rutisson at
Wed Oct 12 02:07:04 PDT 2011

Thanks for the reviews everyone!

I'll go ahead an push this change now.

Dmitry, I created this CR to keep trak of the issue with path names 
containing spaces:

7099952 The src/os/posix/launcher/launcher.script does not support paths 
that contain spaces

I went ahead and pasted your email in as SUN contact. Hope that is ok.

Thanks again,

On 2011-10-11 13:30, Bengt Rutisson wrote:
> Dmitry,
> Thanks for looking at this closely. I would like to make sure that the 
> script is possible to run on Solaris as soon as possible. The intent 
> with my CR was not to improve or clean up the script. Thus, I am not 
> really inclined to go down the path of changing too much in the script 
> within the scope of this CR.
> I think you point out some relevant issues with the current script. 
> But I think they will be better handled in separate CRs.
> Thanks again.
> Bengt
> On 2011-10-11 13:27, Dmitry Samersoff wrote:
>> Bengt,
>> On 2011-10-11 15:19, Dmitry Samersoff wrote:
>>> 102 JDK=${ALT_JAVA_HOME%%/jre};
>>> doesn't work with plain
>>> it have to be
>>> JDK=`echo ${ALT_JAVA_HOME} | sed -e "s:/jre::g"`
>> PS: Is you really whant to remove all occurrence of /jre within 
>> ALT_JAVA_HOME as original script does?
>> Probably you need just to strip /jre suffix, so
>> it should be:
>> > JDK=`echo ${ALT_JAVA_HOME} | sed -e "s:/jre$::"`
>> -Dmitry

More information about the hotspot-runtime-dev mailing list