Code review request: 2 Native Memory Tracking bugs

David Holmes david.holmes at
Wed Aug 1 19:02:05 PDT 2012

Hi Zhengyu,

As someone else said (sorry lost the email) we should not be using 
unadorned print outs in the code. The shouldNotReachHere should be a 
fatal with suitable message. The plain tty->print should either be 
warnings or guarded by some debug/tracing/verbosity flag.


On 2/08/2012 3:39 AM, Zhengyu Gu wrote:
> These are two simple fixes for NMT.
> CR: 7185614 NMT ON: "check by caller" assertion failed on nsk
> ThreadMXBean test
> (
>    The assertion was incorrect, since there can be a race condition
> between caller's check and assertion. The assertion is now removed,
> shutdown in progress is checked instead.
> CR: 7187429 NMT ON: Merge failure should cause NMT to shutdown
> (
>    Out-of-memory is the only cause to merge failure, to be consistent,
> NMT should shutdown itself.
> Webrev:
> Thanks,
> -Zhengyu

More information about the hotspot-runtime-dev mailing list