RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

Tim Bell tim.bell at oracle.com
Sat Aug 11 13:15:26 PDT 2012

On 08/11/12 12:12, Daniel D. Daugherty wrote:
> On 8/11/12 3:49 AM, Dmitry Samersoff wrote:
>> Dan,
>> On 2012-08-11 01:08, Daniel D. Daugherty wrote:
>>> One-line addition of two double quotes... Gotta love Windows.
>> It's not about windows. Unpack workspace to "mypath with spaces" and try
>> to build hotspot.

As in the old joke: The patient says 'Doctor, it hurts when I do this'  
Doctor says: 'Don't do that then'

Paths with spaces in them are painful.  Fixing it would take a lot of 
work, and the job would never stay finished.  'Don't do that' :-)

>> Looks good for me.
> I'm pretty sure that in this failure mode it was the backslashes.
> Tim B. can confirm.

That was it.

Thanks for the extra review-


> Sorry I won't be able to list you as a reviewer since the job was
> already in the JPRT-hotspotwest queue as of midnight last night.
> Dan

More information about the hotspot-runtime-dev mailing list