Code Review fix for 8005044 remove crufty '_g' support from HS runtime code
kelly.ohair at oracle.com
Tue Dec 18 13:31:21 PST 2012
I suspected that, but you sent it to build-dev and I was expecting makefile changes.
So good to go from build-dev
On Dec 18, 2012, at 1:18 PM, Ron Durbin wrote:
> Dan is correct.
> -----Original Message-----
> From: Daniel D. Daugherty
> Sent: Tuesday, December 18, 2012 2:14 PM
> To: Kelly O'Hair
> Cc: serviceability-dev at openjdk.java.net; build-dev; hotspot-runtime-dev at openjdk.java.net
> Subject: Re: Code Review fix for 8005044 remove crufty '_g' support from HS runtime code
> The Makefile changes were reviewed under 7153050 last week and pushed to RT_Baseline.
> See the attached notification.
> On 12/18/12 2:06 PM, Kelly O'Hair wrote:
>> I don't see any makefile changes.
>> On Dec 18, 2012, at 12:46 PM, Daniel D. Daugherty wrote:
>>> I'm sponsoring this code review request from Ron Durbin. This change
>>> is targeted at JDK8/HSX-25 in the RT_Baseline repo.
>>> Sending again with correct subject line, bug URLs and webrev URL.
>>> This set of changes removes the runtimesupport for generation of debug versions that follow _g semantics.
>>> JDK-8005044 remove crufty '_g' support from HS runtime code
>>> Files have been modified to remove all reference and support for debug versions that follow _g semantics.
>>> Passed JPRT last night:
>>> Additional Testing In process: (suggested by Dan):
>>> - test with shared archive creation and use; see the e-mail
>>> from Coleen
>>> - just a usage message; visual inspection of the code
>>> - comments only; no testing needed
>>> - the only code changes come into play when the "gamma"
>>> launcher is used
>>> - and when JAVA_HOME refers to a valid JDK, the function
>>> fakes up a JVM path so that callers using the JVM path
>>> to find other things in the JDK will work.
>>> - I can't find any way that the actual JVM path value
>>> that is returned is exposed
>>> - I don't see a way to test this other than have a debug
>>> printf() or manual code inspection.
More information about the hotspot-runtime-dev