ConstantPoolCacheEntry::print() should use its first argument
tom.rodriguez at oracle.com
Fri Feb 24 09:50:15 PST 2012
On Feb 24, 2012, at 1:13 AM, David Holmes wrote:
> I've regenerated a webrev at:
> Can we please get a second hotspot reviewer
> On 23/02/2012 8:00 PM, David Holmes wrote:
>> Hi Kris,
>> I've filed 7148126 for this and will sponsor the push.
>> On 23/02/2012 6:52 PM, Krystal Mok wrote:
>>> Hi all,
>>> A minor issue:
>>> Running experiments that crash the VM lead me to some weird output on
>>> stdout during VM error reporting .
>>> Turns out it's from ConstantPoolCacheEntry::print(outputStream* st, int
>>> index). But instead of printing to "st", it's printing to "tty".
>>> The call path:
>>> os::print_register_info(outputStream *st, void *context)
>>> os::print_location(outputStream* st, intptr_t x, bool verbose)
>>> oopDesc::print_on(outputStream* st)
>>> constantPoolCacheKlass::oop_print_on(oop obj, outputStream* st)
>>> ConstantPoolCacheEntry::print(outputStream* st, int index)
>>> I checked that the last function is the only one not using the "st"
>>> A patch to fix it, diff against jdk8/jdk8/hotspot master: 
>>> Could anyone please sponsor this patch?
>>> Kris Mok
>>> : https://gist.github.com/1891517#file_command_prompt
>>> : https://gist.github.com/1891517#file_fix_against_jdk8_master.patch
More information about the hotspot-runtime-dev