RFR, S, 7120450: complete information dumped by frame_describe

Christian Thalinger christian.thalinger at oracle.com
Tue Jan 24 01:57:51 PST 2012

Looks good.  Only one little nit:

+     intptr_t* esp = * interpreter_frame_esp_addr();

Could you remove that extra space for the dereference?  It looked like a multiplication at first sight :-)

-- Chris

On Jan 18, 2012, at 5:29 PM, Bertrand Delsart wrote:

> Second RFR related to frame_describe:
> http://cr.openjdk.java.net/~bdelsart/7120450/00/webrev/
> This comes on top of 7120448, currently being submitted.
> Goal of that RFR was to enhance x86/PPC with stuff we had added to our embedded plarforms, namely information about ricochet frames and basic information for non standard frames. This only impacts debugging code (dumps generated by pfl() calls or temporarily added to the JVM during development).
> We did fix a small issue in frame::describe. is_deoptimized() could
> fail on assertions for some frames. This was discovered by stress testing the calls with (non submited) print_frame_layout() calls in in the transitions back from the JVM to Java (to ensure the robustness of the dump and the adequacy of the information).
> Also called print_frame_layout() from trace_method_handle to debug ricochet frames information. This is not part of this RFR since the changes are more intrusive.
> Thanks,
> Bertrand.
> -- 
> Bertrand Delsart,               bertrand.delsart at oracle.com,
> Sun-Oracle France, 180 av. de l'Europe, ZIRST de Montbonnot,
> 38334 Saint Ismier,                                  FRANCE

More information about the hotspot-runtime-dev mailing list