Pls review 7091418: FX priority class from Solaris should be available to JVM )

Daniel D. Daugherty daniel.daugherty at
Thu Jan 26 09:34:58 PST 2012

On 1/25/12 4:08 PM, Paul Hohensee wrote:
> New webrev at

Thumbs up!

Don't forget to use this bug ID when you commit:

     7082553 2/3 Interpret Thread.setPriority(Thread.MAX_PRIORITY) to mean
                 FX60 on Solaris 10 and 11

It would be nice to update the copyrights...

     No comments.

     No comments.

     typo line 36: 'create' -> 'created'

     nit line 3798 - deleted a blank line - why?

     lines 3998-4031 are pretty domain specific; I can't vouch for the
         correctness one way or the other

     lines 4000, 4012, 4022 seem a bit long

     nit lines 4036-7 - deleted blanks lines - why?

     No comments.

     No comments.

     line 78: The comment on line 75 in os.hpp says that the VMThread
         uses NearMaxPriority so this comment (nor the original
         comment) make sense.

     nit line 3491: "VM thread" -> "the VM thread"

     Why am I reminded of the scene in "Spinal Tap" where they
     are talking about the amp that goes up to 11 instead of 10?

     No (real) comments.

More information about the hotspot-runtime-dev mailing list