Request for review (XS): 7140909 Visual Studio project builds broken: need to define INCLUDE_TRACE
bengt.rutisson at oracle.com
Mon Jan 30 09:15:50 PST 2012
Staffan and Keith, thanks for the very quick reviews!
On 2012-01-30 16:26, Keith McGuigan wrote:
> Looks fine.
> - Keith (openjdk: kamg)
> On 1/30/2012 9:21 AM, Bengt Rutisson wrote:
>> Hi all,
>> Could I please have a couple of review for this really small change:
>> There is only one line changed, so I'll include the diff here as well:
>> The fix for "7115199: Add event tracing hooks and Java Flight Recorder
>> infrastructure" added this to make\windows\makefiles\vm.make:
>> !ifndef JAVASE_EMBEDDED
>> CPP_FLAGS=$(CPP_FLAGS) /D "INCLUDE_TRACE"
>> To keep the Visual Studio projects working the same type of change needs
>> to be made to src\share\tools\ProjectCreator\BuildConfig.java
>> This will only affect Visual Studio projects created with the
>> ProjectCreator tool (create.bat). This does not affect "normal" Windows
>> builds or JPRT builds.
More information about the hotspot-runtime-dev