-XX:MaxDirectMemorySize argument parsing
cdennis at terracottatech.com
Thu Jun 7 08:17:25 PDT 2012
+1 - using the error code makes sense to me.
On Jun 7, 2012, at 10:20 AM, Alan Bateman wrote:
> On 07/06/2012 14:28, Chris Dennis wrote:
>> Yes, I'm listed under "Terracotta Inc. (Christopher Dennis)".
>> There is one additional complication to this in that the LimitDirectMemory test in the jdk sources is currently broken. The patch below "fixes" the test - but leaves two open questions:
>> What should the grep be looking for? This is JDK test asserting on output generated by Hotspot - that seems a little screwed up to me, right?
> it might be nicer to just check the exit code and not depend on the error message. Just on logistics, as hotspot and jdk changes take a different route into master it means that we'll need to wait until the hotspot changes get to jdk8/jdk8 (and probably down to jdk8/tl) before pushing a change to the LimitDirectMemory.sh test.
More information about the hotspot-runtime-dev