7172708: 32/64 bit type issues on Windows
coleen.phillimore at oracle.com
Thu Jun 7 14:26:42 PDT 2012
Looks good to me.
On 6/6/2012 4:26 PM, David Holmes wrote:
> This passed our builds and basic tests.
> Looks okay to me. We need one more runtime reviewer.
> On 6/06/2012 9:44 AM, David Holmes wrote:
>> Hi Chris,
>> This looks reasonable to me but I'm not a windows programming expert.
>> I'm running it through our JPRT build/tests system to check it out.
>> David Holmes
>> On 5/06/2012 11:46 PM, Chris Dennis wrote:
>>> diff --git a/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> --- a/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> +++ b/src/share/vm/utilities/globalDefinitions_visCPP.hpp
>>> @@ -220,9 +220,15 @@
>>> #define PRIu64 "I64u"
>>> #define PRIx64 "I64x"
>>> +#ifdef _LP64
>>> +#define PRIdPTR "I64d"
>>> +#define PRIuPTR "I64u"
>>> +#define PRIxPTR "I64x"
>>> #define PRIdPTR "d"
>>> #define PRIuPTR "u"
>>> #define PRIxPTR "x"
>>> #define offset_of(klass,field) offsetof(klass,field)
More information about the hotspot-runtime-dev