-XX:MaxDirectMemorySize argument parsing
david.holmes at oracle.com
Thu Jun 7 18:41:19 PDT 2012
On 8/06/2012 12:20 AM, Alan Bateman wrote:
> On 07/06/2012 14:28, Chris Dennis wrote:
>> Yes, I'm listed under "Terracotta Inc. (Christopher Dennis)".
>> There is one additional complication to this in that the
>> LimitDirectMemory test in the jdk sources is currently broken. The
>> patch below "fixes" the test - but leaves two open questions:
>> What should the grep be looking for? This is JDK test asserting on
>> output generated by Hotspot - that seems a little screwed up to me,
> it might be nicer to just check the exit code and not depend on the
> error message.
Agreed. Seems cleaner.
> Just on logistics, as hotspot and jdk changes take a
> different route into master it means that we'll need to wait until the
> hotspot changes get to jdk8/jdk8 (and probably down to jdk8/tl) before
> pushing a change to the LimitDirectMemory.sh test.
Also is the hotspot fix targeted for 8 and 7u, or just 8?
Still need additional reviewer from runtime - thanks.
More information about the hotspot-runtime-dev