Request for review (S): add the JRE name to the error log

Krystal Mok rednaxelafx at
Wed Jun 13 19:27:14 PDT 2012

Thank you for the reviews, Chris, Coleen and John!

On Thu, Jun 14, 2012 at 9:38 AM, John Rose <john.r.rose at> wrote:

> On May 16, 2012, at 1:26 PM, Christian Thalinger wrote:
> I looked at the changes and I think this is the right way to implement it.
>  It will definitely help debugging some strange crashes like the one
> mentioned.
> I suggest that the following should be turned into real code the returns
>   assert(name_oop != NULL, "java_runtime_name shouldn't be null")
> (When the JVM crashes is exactly when such asserts prove false.  At that
> point we want all the crash info.)
> Ahh...yes, you're right. I agree this line should be changed to just
returning NULL.
Chris, could you please take care of this when pushing?


> — John
-------------- next part --------------
An HTML attachment was scrubbed...

More information about the hotspot-runtime-dev mailing list