Request for review (S): add the JRE name to the error log

Christian Thalinger christian.thalinger at
Thu Jun 14 10:57:02 PDT 2012

On Jun 13, 2012, at 7:27 PM, Krystal Mok wrote:

> Thank you for the reviews, Chris, Coleen and John!
> On Thu, Jun 14, 2012 at 9:38 AM, John Rose <john.r.rose at> wrote:
> On May 16, 2012, at 1:26 PM, Christian Thalinger wrote:
>> I looked at the changes and I think this is the right way to implement it.  It will definitely help debugging some strange crashes like the one mentioned.
> I suggest that the following should be turned into real code the returns NULL:
>   assert(name_oop != NULL, "java_runtime_name shouldn't be null")
> (When the JVM crashes is exactly when such asserts prove false.  At that point we want all the crash info.)
> Ahh...yes, you're right. I agree this line should be changed to just returning NULL.
> Chris, could you please take care of this when pushing?

Sure.  I also changed the output format slightly to be more like -version:

# A fatal error has been detected by the Java Runtime Environment:
#  SIGSEGV (0xb) at pc=0x0135f581, pid=9986, tid=2819574640
# JRE version: Java(TM) SE Runtime Environment (7.0_04-b20)
# Java VM    : Java HotSpot(TM) Server VM (24.0-b14-internal-jvmg mixed mode linux-x86 )
# Problematic frame:
# V  []  frame::oops_do_internal(OopClosure*, CodeBlobClosure*, RegisterMap*, bool)+0x2f

$ java -version
java version "1.7.0_04"
Java(TM) SE Runtime Environment (build 1.7.0_04-b20)
Java HotSpot(TM) Server VM (build 24.0-b14-internal-jvmg, mixed mode)

Here is the webrev:

-- Chris

> Thanks,
> Kris
> — John

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the hotspot-runtime-dev mailing list