Review Request: 8005879: Add -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 to builds on Mac
david.dehaven at oracle.com
Thu Feb 14 09:04:24 PST 2013
> Here are a series of patches that adds the following to all native compile lines on macosx:
> -DMAC_OS_X_VERSION_MAX_ALLOWED=1070 -DMAC_OS_X_VERSION_MIN_REQUIRED=1070
I know I'm not a reviewer, but I have an opinion anyways :)
Using "-mmacosx-version-min=10.7" seems more appropriate for the latter, this is passed to the linker as well which I believe sets version information in the Mach-O headers (in the form of a load command) to prevent it from being loaded on older systems. The MIN_REQUIRED macro is set to a value that matches what's passed to the -mmacosx-version-min argument, so it doesn't need to be provided.
More information about the hotspot-runtime-dev