Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly
Daniel D. Daugherty
daniel.daugherty at oracle.com
Wed Feb 20 08:57:26 PST 2013
On 2/20/13 9:34 AM, Coleen Phillimore wrote:
> This looks good.
Thanks for the review! Don't know if Ron is having the same connectivity
problems I'm having this morning, but my access into OWAN is going up
> It looks like the webrev was updated to get rid of the unused
> variable, so that is good.
The webrev was not updated.
> Is there a test for ErrorHandlerTest in our repository already?
ErrorHandlerTest? Is there yet another possible test that we don't
> On 2/19/2013 6:48 PM, Daniel D. Daugherty wrote:
>> I'm sponsoring this code review request from Ron Durbin. This change
>> is targeted at JDK8/HSX-25 in the RT_Baseline repo.
>> I have a proposed fix for the following bug:
>> 6799919 Recursive calls to report_vm_out_of_memory are handled
>> This is one of those bug fixes where the commit message nicely describes
>> the change:
>> 6799919: Recursive calls to report_vm_out_of_memory are handled
>> Summary: report_vm_out_of_memory() should allow
>> VMError.report_and_die() to handle multiple out of native memory errors.
>> Reviewed-by: dcubed, <other-reviewers>
>> Contributed-by ron.durbin at oracle.com
>> Here is the webrev URL:
>> - See the READ_ME file attached to the JDK-6799919 for the gory
>> of the testing needed to reproduce this failure and verify the fix
>> - regular JPRT test job is in process
>> Comments, questions and suggestions are welcome.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-runtime-dev