Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

John Rose john.r.rose at
Wed Feb 20 12:13:46 PST 2013

On Feb 20, 2013, at 10:20 AM, Coleen Phillimore <coleen.phillimore at> wrote:

> I noticed that JVM_CONSTANT_Object is no longer used so reused that constant to be PseudoString.   I had an edit to go in the other direction (if a pseudo-string is patched into a constant pool, make it a JVM_CONSTANT_Object), but this didn't fully capture that the constant pool slot also points to a Symbol.

I think the change to is_loadable_constant in constantTag is wrong.  Pseudo-strings are loadable constants.  That's what they are there for (ldc #my_magic_oop).

— John

-------------- next part --------------
An HTML attachment was scrubbed...

More information about the hotspot-runtime-dev mailing list