Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work
coleen.phillimore at oracle.com
Fri Feb 22 05:46:11 PST 2013
On 2/22/2013 1:52 AM, serguei.spitsyn at oracle.com wrote:
> Nice catch.
> Looks good.
> On 2/21/13 9:09 PM, Coleen Phillimore wrote:
>> I'm sorry about this but I need one more review. I omitted one
>> instance of JVM_CONSTANT_Object in templateTable_sparc.cpp and I
>> forgot that you can't make any edit to the VM without making a
>> duplicate edit to the serviceability agent.
>> open webrev at http://cr.openjdk.java.net/~coleenp/8000797_3/
>> Reran runThese jcks and sajdi and mlvm tests on solaris/sparc.
>> On 2/21/2013 6:22 PM, John Rose wrote:
>>> On Feb 20, 2013, at 8:11 PM, Coleen Phillimore
>>> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>>
>>>> Thanks to John's feedback, I've modified this change again to
>>>> revert back to my original change to zero out the Symbol* to
>>>> indicate pseudo string (could be thought of as "patched string").
>>>> Also cleaned up unused constant pool Object constant and unused
>>>> flags. Reran all the tests.
>>> Good; lots of nice deletions. You can use me as a reviewer. — John
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-runtime-dev