RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Nov 11 12:06:07 PST 2013

It looks good.

The only one nit is about the line:

  160         System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags());

If one or both ofArguments.getJVMArgs() and Arguments.getJVMFlags() 
return null
(not sure if it is the case) then the output will have "null" like this:
   "Command line: nullnull"

Would it make sense to keep the original checks for non-null strings?


On 11/11/13 11:28 AM, Staffan Larsen wrote:
> The problem here is that ‘jinfo -flags’ only looks at the command line, but if a user has changed a flag after the VM started (for example by using ‘jinfo -flag’) that new value does not show up.
> I am changing the output so that ‘jinfo -flags’ now prints something like this:
> Non-default VM flags: -XX:InitialHeapSize=268435456 -XX:MaxHeapSize=4294967296 -XX:+PrintGCDetails -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseParallelGC
> Command line: -XX:+PrintGCDetails
> webrev: http://cr.openjdk.java.net/~sla/6606002/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-6606002
> Thanks,
> /Staffan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131111/45423fa3/attachment.html 

More information about the hotspot-runtime-dev mailing list