RFR (S) JDK-8026065: InterfaceMethodref for invokespecial must name a direct superinterface
karen.kinnear at oracle.com
Sun Nov 24 14:10:26 PST 2013
This looks great! And thank you.
I assume you ran some set of test examples with and without the verifier?
One question in verifier.cpp:
You only need the is_same_or_direct check if cp->tag_at(index).value() == JVM_CONSTANT_InterfaceMethodef right?
If so, would it make sense to check that before doing the extra checking rather than before throwing the exception?
This would maybe be a bit quicker and less risk of breaking existing code.
The code logic here gets awkwardly nested, so I understand if you tried that and this was cleaner.
On Nov 24, 2013, at 4:34 PM, Lois Foltan wrote:
> Please review the following fix:
> Bug: InterfaceMethodref for invokespecial must name a direct superinterface
> Summary of fix:
> Add verification to check that InterfaceMethodref for invokespecial names a method in a
> direct superinterface of the current class or interface. See (JVMS draft 0.7.0) 4.9.2 Structural Constraints,
> "Each invokespecial instruction must name an instance initialization method (2.9), or
> must reference a method in the current class or interface, a method in a superclass of the
> current class or interface, or a method in a direct superinterface of the current class or interface."
> jtreg hotspot/test/*, JDK java.lang & java.util, vm.quick.testlist, JCK 8 *, JDK1.4 JCKs, defmeth tests
> Thank you, Lois
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-runtime-dev