RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon Apr 7 21:19:21 UTC 2014

Hi Coleen,

thanks for the review and the sponsoring!

Sorry I can't help with closed changes, I didn't expect any
with this one.

Best regards,

From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
Sent: Monday, April 07, 2014 7:41 PM
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top

The change looks fine.  I can sponsor it unless someone else would like to.
On 4/7/14, 6:07 AM, Lindenmaier, Goetz wrote:

could I please get a review of this change?  It fixes a rather
obvious error, and is really simple.

Is runtime the wrong mainling list for interpreter changes?  Should I
post to comp?

Best regards,

From: Lindenmaier, Goetz
Sent: Donnerstag, 3. April 2014 15:33
To: hotspot-runtime-dev at openjdk.java.net<mailto:hotspot-runtime-dev at openjdk.java.net>
Subject: RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top


please review an test this small fix to the interpreters.  I please need
a sponsor.

JNIHandleBlock::_top is an int field. Various places store into
this field using a pointer store. On 64-bit platforms
this can cause errors.

This change adapts the corresponding operations on sparc
and both x86 variants to use fixed 32-bit operations.

Best regards,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140407/2d1773e1/attachment.html>

More information about the hotspot-runtime-dev mailing list