RFR : (process) Add instrumentation to help diagnose JDK-6573254
Daniel D. Daugherty
daniel.daugherty at oracle.com
Tue Aug 19 13:30:33 UTC 2014
On 8/19/14 6:57 AM, Ivan Gerasimov wrote:
> Hello again!
> I updated the patch to cover situations when the exiting thread isn't
> I also added load_acquire/store_release for the sake of accuracy, even
> though on Windows they seem to add nothing to the volatile access.
Thumbs up. I like this version even more.
> If the updated patch looks Okay, I'll need a sponsor to push it.
> Sincerely yours,
> On 19.08.2014 6:42, David Holmes wrote:
>> On 19/08/2014 10:12 AM, Ioi Lam wrote:
>>> With the Windows/x86/x64 memory model, is the write to
>>> vm_getting_terminated guaranteed to be observable by java_start()?
>> In the general case, not immediately. For the threads actually of
>> interest the logic that tells the threads to terminate happens after
>> the write to the flag, and that logic contains sufficient
>> "synchronization" that if the termination logic is correct then the
>> flag must also be visible.
>>> - Ioi
>>> On 8/18/14, 2:19 PM, Ivan Gerasimov wrote:
>>>> This is a request to temporarily add some instrumentation code to
>>>> hotspot to help diagnose the intermittent failure on Windows, which
>>>> results in a wrong exit code of (sub-)process.
>>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8055338
>>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8055338/0/webrev/
>>>> Sincerely yours,
More information about the hotspot-runtime-dev