RFR(s): 8067187: -XX:MaxMetaspaceSize=20m -Xshare:dump caused JVM to crash
calvin.cheung at oracle.com
Wed Dec 17 00:49:26 UTC 2014
Thanks for your review and offline discussions.
On 12/16/2014 4:42 PM, Jiangli Zhou wrote:
> Hi Calvin,
> After looking more into the code, I think we don't have enough size
> information for doing the check in Metaspace::global_initialize().
> That's because the metaspace has other memory usages other than the
> shared spaces.
> On 12/15/2014 11:12 AM, Jiangli Zhou wrote:
>> Hi Calvin,
>> Would it better to do the size check in
>> Metaspace::global_initialize() along with the rest of the shared
>> space size checks?
>> On 12/12/2014 12:42 PM, Calvin Cheung wrote:
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8067187
>>> This fix is to add a check on the MaxMetaspaceSize when performing
>>> CDS archive dumping.
>>> With the fix, instead of a crash, it will print and error message
>>> like the following and exit:
>>> Java HotSpot(TM) 64-Bit Server VM warning:
>>> The MaxMetaspaceSize of 20971520 bytes is not large enough.
>>> Either don't specify the -XX:MaxMetaspaceSize=<size>
>>> or increase the size to at least 33554432.
>>> Tested manually via command line and jtreg test on the new test.
>>> webrev: http://cr.openjdk.java.net/~ccheung/8067187/webrev/
More information about the hotspot-runtime-dev