RFR: JDK-8033464 and JDK-8033931 - Linux code cleanup

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Mar 24 19:53:09 UTC 2014


Thumbs up.

This time I compared the diffs for these two changesets from JDK9:

changeset:   5879:c2626e4f0c80
user:        dcubed
date:        Fri Feb 07 11:47:24 2014 -0800
summary:     8033931: Several nightly tests failing with assert(imin < 
imax) fai
led: Unexpected page size

changeset:   5875:2c2a99f6cf83
parent:      5871:c86519f8d826
user:        coleenp
date:        Thu Feb 06 14:28:35 2014 -0500
summary:     8029775: Solaris code cleanup

with the patch. The only differences are white space, timestamps
and diff context anchors.


On 3/24/14 1:47 PM, Gerald Thornbrugh wrote:
> Hi,
> I am a member of the Oracle Hotspot group and there is an initiative 
> to clean up
> things like uninitialized variables and unclosed file descriptors in 
> JDK8. This is a
> backport of fixes that have already been putback into JDK9. I have run 
> UTE and
> JPRT tests on Linux machines without problems. The below webrev show 
> the fixes for
> the Linux area.
> Bugs:
> JDK-8033464 is not visible because it has been marked as Oracle 
> confidential.
> JDK-8033464 describes a JDK8 Linux specific code cleanup to address
> possible uninitialized variables and unclosed file descriptors. These 
> issues
> were addressed in the fix.
> https://bugs.openjdk.java.net/browse/JDK-8033464
> JDK-8033931 is a JDK9 issue with an assert that was putback as part of 
> the
> fix for JDK-8033464.  It will also be addressed with this putback.
> https://bugs.openjdk.java.net/browse/JDK-8033931
> Webrev:
> http://cr.openjdk.java.net/~dcubed/for_gthornbr/8033464-webrev/1-jdk8u-hs-dev/ 
> Please review my changes and let me know if you have questions.
> Thanks,
> Gerald Thornbrugh

More information about the hotspot-runtime-dev mailing list