RFR (round2) JDK-8038654: Separate SymbolTable and StringTable code

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Mon May 5 13:25:11 UTC 2014


I ran a testbuild on ppc64 without precompiled headers -- worked fine!

Best regards,

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Stefan Karlsson
Sent: Montag, 5. Mai 2014 10:00
To: Gerard Ziemski; hotspot-runtime-dev at openjdk.java.net
Cc: Christian Thalinger
Subject: Re: RFR (round2) JDK-8038654: Separate SymbolTable and StringTable code

On 2014-05-02 18:57, Gerard Ziemski wrote:
> hi all,
> Please review this simple enhancement, which refactors symbolTable 
> into symbolTable and stringTable
> The changes since rev0:
> Re: Stefan Karlsson
> - sorted includes
> - replaced "#include symbolTable.hpp" with just "#include 
> stringTable.hpp" as needed
> - stringTable.cpp no longer includes symbolTable.hpp
> - stringTable.hpp forward declares Symbol instead of including 
> symbolTable.hpp
> Webrev: http://cr.openjdk.java.net/~gziemski/8038654_rev1
> Bug: https://bugs.openjdk.java.net/browse/JDK-8038654
> Tested with hotspot jtreg, vm.quicklooks and JPRT. Locally builds on 
> Mac OS X and Linux.

Looks good to me. Thanks!

Could you try to compile without precompiled headers? You can do this by 
passing USE_PRECOMPILED_HEADER=0 to make.


> Thank you.

More information about the hotspot-runtime-dev mailing list