RFR(XS): JDK-6904403 assert(f == k->has_finalizer(), "inconsistent has_finalizer") with debug VM

Coleen Phillimore coleen.phillimore at oracle.com
Tue May 27 15:02:58 UTC 2014

This is excellent.  Thank you for adding a test.  I have a couple 
comments but they are sort of simple things.

1.  In InstanceKlass::has_redefined_super() can you make "klass' an 
InstanceKlass* and cast to InstanceKlass on line 1491 instead to avoid 
the casting.   You'll only have InstanceKlass on the way up.

2.  The new test files need copyrights!   Except maybe the manifest one 

3.  Can you make jtreg commands to do the things in the script?  I 
didn't see anything very unusual.

Thank you for doing this.  It's really helpful and it seems it found a 
bug also (super classes?)


On 5/24/14, 1:17 PM, Dmitry Samersoff wrote:
> Coleen,
> http://cr.openjdk.java.net/~dsamersoff/JDK-6904403/webrev.03/
> This is new version of the fix.
> Changes:
> 1. Added testcase
> 2. Check entire class hierarchy for redefined classes
>     as any of supers could be redefined and cause assert.
> -Dmitry
> On 2014-04-16 16:56, Dmitry Samersoff wrote:
>> Hi Everybody,
>> Please review small changes.
>> http://cr.openjdk.java.net/~dsamersoff/JDK-6904403/webrev.01/
>> This fix tells to JVM to don't assert if the class was redefined.
>> Please notice, these changes doesn't make redefined finalyzers working.
>> It's a large project which is out of scope of this changes.
>> -Dmitry

More information about the hotspot-runtime-dev mailing list