RFR (XS) JDK-8072694: Need errno info when CDS archive creation fails
lois.foltan at oracle.com
Mon Feb 9 13:05:41 UTC 2015
Looks good. Really minor comment:
- line #391 - you might want to format the error message
how it is formatted in FileMapInfo::open_for_read(). In that
errno info is put in parentheses. I don't have a preference
for either format
just that both formats are consistent.
I don't need to see a new webrev.
On 2/9/2015 7:42 AM, harold seigel wrote:
> Please review this small fix for bug 8072694.
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8072694_errno/
> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8072694
> The fix was regression tested with JPRT, JCK lang and VM tests,
> hotspot JTReg, and NSK quick tests. In addition, I ran tests that
> intentionally failed to create the archive and checked the generated
> errno messages.
> Thanks, Harold
More information about the hotspot-runtime-dev