RFR 8054494: Remove sun.misc.Unsafe.monitorEnter, monitorExit and tryMonitorEnter
coleen.phillimore at oracle.com
Tue Jan 13 19:30:51 UTC 2015
The second webrev looks good to me also, but I had a question about your
On 1/9/15, 10:52 AM, Paul Sandoz wrote:
> This "forest" webrev [*] removes the monitor related methods from Unsafe.
> The temptation to cleanup code in unsafe.cpp was resisted. I gather now that HotSpot Express no longer exists the grouping of registered native methods can be cleaned up plus there is dead code related to prefetch support. I propose to cleanup in a future patch.
Is there an RFE for this? I thought you had a webrev before the
coordinated pushes to clean up code. Was this the code?
> The monitor methods resurface on WhiteBox because i noticed some associated Unsafe usages within hotspot Java tests. Rather than attempting to change such tests i thought it better to move the existing functionality.
> Now that WhiteBox has moved to the top level repository i could update ProcessBuilder/Basic.java to use WhiteBox. I held off doing that for now (it seems a little involved to get the relevant classes on the classpath for the executing tests with such a dependency).
> A JPRT job using the hotspot testset passed. Is that the correct testset to use?
> [*] Unfortunately "webrev -f" does not create a patch per repo as listed by "hg tlist".
More information about the hotspot-runtime-dev